Skip to content

fix: flip around division #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 1 commit into from
Jun 28, 2022
Merged

fix: flip around division #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../main/java/org/hypertrace/core/query/service/pinot/converters/PinotFunctionConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ private String functionToStringForAvgRate(
.getSeconds();

return String.format(
"SUM(%s / %s)", columnName, (double) aggregateIntervalInSeconds / rateIntervalInSeconds);
"SUM(%s) / %s", columnName, (double) aggregateIntervalInSeconds / rateIntervalInSeconds);
}

private String convertCount() {
Expand Down
2 changes: 1 addition & 1 deletion ...est/java/org/hypertrace/core/query/service/pinot/QueryRequestToPinotSQLConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -914,7 +914,7 @@ public void testQueryWithAverageRateInOrderBy() {
+ "' "
+ "and ( start_time_millis >= 1637297304041 and start_time_millis < 1637300904041 and service_id != 'null' ) "
+ "group by service_id, service_name "
+ "order by SUM(error_count / 3600.0) "
+ "order by SUM(error_count) / 3600.0 "
+ "limit 10000",
viewDefinition,
executionContext);
Expand Down
4 changes: 2 additions & 2 deletions ...t/java/org/hypertrace/core/query/service/pinot/converters/PinotFunctionConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ void convertAvgRateFunction() {
.thenReturn(Optional.of(Duration.ofSeconds(10)));

assertEquals(
"SUM(foo / 2.0)",
"SUM(foo) / 2.0",
new PinotFunctionConverter()
.convert(
mockingExecutionContext,
Expand All @@ -223,7 +223,7 @@ void convertAvgRateFunction() {
.thenReturn(Optional.of(Duration.ofSeconds(20)));

assertEquals(
"SUM(foo / 4.0)",
"SUM(foo) / 4.0",
new PinotFunctionConverter()
.convert(
mockingExecutionContext,
Expand Down