This repository was archived by the owner on Nov 14, 2023. It is now read-only.
Using DistinctCountHLL instead of DistinctCount AND division after aggregation for leveraging startree#22
Merged
Harnoor-se7en merged 4 commits intorzp_mainfrom Jul 19, 2022
Conversation
Harnoor-se7en
changed the title
Harnoor-se7en
changed the title
Sunn-y-Arora
approved these changes
Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startree index doesn't work on the
DISTINCTCOUNToperator and we have slow queries havingDISTINCTCOUNTagg andSUM(DIV(num_calls, 86400.0)).Because the results of the queries of these operators cannot be merged across startree nodes, Hence we need to change them to
DISTINCTCOUNTHLLandSelect SUM(numcalls)/86400.0. In the last meeting with Laxman where I was getting the below startree indices doc reviewed by him, I raised the above and some other doubts.https://docs.google.com/document/d/1BfP6qzNlXN7euDfmceHTN5gYpkKuqcg9v1QDurk6ERk/edit#bookmark=id.x4llp69ulvpt
They also had the same issue and they fixed it 2 weeks back in hypertrace/query-service#143 and hypertrace/query-service#147. Hence am picking the same change.
Changes
DistinctCountHLLsupport (will add configuration in Kube manifests) and from now on we will be using this operator instead ofDistinctCount.