Fixing the missing commands to ESC #7724
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After using the turtle mode, depending on the configuration of the hardware, not all commands are apparently completely transferred to the ESCs. This means that some motors still have the wrong direction of rotation, even though the turtle mode has been deactivated. This queue addresses these issues. The mentioned error has thus been eliminated and i couldn't see any disadvantages, but i'm not a developer and grateful for any other better solution.
DzikuVx
requested changes
Jan 7, 2022
Member
DzikuVx
left a comment
DzikuVx
left a comment
There was a problem hiding this comment.
This is a no-go. We can not block execution for 10ms times 10 when sending commands. executeDShotCommands should have a fallback scheduler to actually execute next command only when those 10ms passed. Blocking will not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using the turtle mode, depending on the configuration of the hardware, not all commands are apparently completely transferred to the ESCs. This means that some motors still have the wrong direction of rotation, even though the turtle mode has been deactivated. This queue addresses these issues.
The mentioned error has thus been eliminated
and i couldn't see any disadvantages, but i'm not a developer and grateful for any other better solution.