-
Notifications
You must be signed in to change notification settings - Fork 11
handle applicant ssn removal for faa flow #5927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayreddy519
reviewed
Nov 28, 2025
app/domain/operations/financial_assistance/on_determination/people/create_or_update.rb
Show resolved
Hide resolved
jayreddy519
approved these changes
Dec 1, 2025
Contributor
jayreddy519
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spec coverage, LGTM.
…moval-from-faa-flow
TristanB17
approved these changes
Dec 1, 2025
Contributor
TristanB17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
jacobkagon
added a commit
that referenced
this pull request
Dec 8, 2025
* Revert "loud cancel if previously published (#5804)" This reverts commit 3641b97. * Revert "modifies ATP outbound to exclude migrated FA applications (#5822)" This reverts commit 988db6a. * Revert "adding re-run renewal and script to handle re-determinations (#5910)" This reverts commit d60c2d6. * Revert "add error handling for individual with existing primary broker role (#5892)" This reverts commit a1d8320. * Revert "handle applicant ssn removal for faa flow (#5927)" This reverts commit 1b253de. * Revert "make time displayed consistent across evidence tables (#5930)" This reverts commit 34cb662. * rebuild family eligibility determination for hub call override data fix (#5936) add call to rebuild family eligibility determination operation to reflect pending status Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com> --------- Co-authored-by: Charlie Parker <charlie.parker@ideacrew.com> Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
sri49
pushed a commit
that referenced
this pull request
Dec 11, 2025
* unset encrypted ssn to circumvent sparse index error * add people update spec * spec fixes --------- Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
lethelpers andbeforeblocks..html_safe.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket: https://app.clickup.com/t/868gbuzk4
A brief description of the changes:
Current behavior: FAA Determination operation is failing when an applicant without an SSN matches an existing person with an SSN due to
E11000 duplicate keymongo error.New behavior: FAA Determination operation sets null applicant ssn.
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.