Skip to content

Conversation

@charlienparker
Copy link
Contributor

@charlienparker charlienparker commented Nov 26, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868gbuzk4

A brief description of the changes:

Current behavior: FAA Determination operation is failing when an applicant without an SSN matches an existing person with an SSN due to E11000 duplicate key mongo error.

New behavior: FAA Determination operation sets null applicant ssn.

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@charlienparker charlienparker marked this pull request as ready for review November 26, 2025 20:02
Copy link
Contributor

@jayreddy519 jayreddy519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spec coverage, LGTM.

Copy link
Contributor

@TristanB17 TristanB17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacobkagon jacobkagon merged commit 1b253de into trunk Dec 1, 2025
273 of 277 checks passed
@jacobkagon jacobkagon deleted the handle-ssn-removal-from-faa-flow branch December 1, 2025 21:01
sri49 added a commit that referenced this pull request Dec 5, 2025
jacobkagon added a commit that referenced this pull request Dec 8, 2025
* Revert "loud cancel if previously published (#5804)"

This reverts commit 3641b97.

* Revert "modifies ATP outbound to exclude migrated FA applications (#5822)"

This reverts commit 988db6a.

* Revert "adding re-run renewal and script to handle re-determinations (#5910)"

This reverts commit d60c2d6.

* Revert "add error handling for individual with existing primary broker role (#5892)"

This reverts commit a1d8320.

* Revert "handle applicant ssn removal for faa flow (#5927)"

This reverts commit 1b253de.

* Revert "make time displayed consistent across evidence tables (#5930)"

This reverts commit 34cb662.

* rebuild family eligibility determination for hub call override data fix (#5936)

add call to rebuild family eligibility determination operation to reflect pending status

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>

---------

Co-authored-by: Charlie Parker <charlie.parker@ideacrew.com>
Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
sri49 pushed a commit that referenced this pull request Dec 11, 2025
* unset encrypted ssn to circumvent sparse index error

* add people update spec

* spec fixes

---------

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants