Skip to content

Conversation

@TristanB17
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868gfy9an

A brief description of the changes:

Current behavior: time displayed on documents + verification history tables is UTC, most other tables use EST

New behavior: time displayed on documents + verification history tables will now also use EST

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

Copy link
Contributor

@jacobkagon jacobkagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobkagon jacobkagon merged commit 34cb662 into trunk Dec 2, 2025
269 of 277 checks passed
@jacobkagon jacobkagon deleted the CU_868gfy9an_dmi_not_staying_in_review branch December 2, 2025 14:11
sri49 added a commit that referenced this pull request Dec 5, 2025
jacobkagon added a commit that referenced this pull request Dec 8, 2025
* Revert "loud cancel if previously published (#5804)"

This reverts commit 3641b97.

* Revert "modifies ATP outbound to exclude migrated FA applications (#5822)"

This reverts commit 988db6a.

* Revert "adding re-run renewal and script to handle re-determinations (#5910)"

This reverts commit d60c2d6.

* Revert "add error handling for individual with existing primary broker role (#5892)"

This reverts commit a1d8320.

* Revert "handle applicant ssn removal for faa flow (#5927)"

This reverts commit 1b253de.

* Revert "make time displayed consistent across evidence tables (#5930)"

This reverts commit 34cb662.

* rebuild family eligibility determination for hub call override data fix (#5936)

add call to rebuild family eligibility determination operation to reflect pending status

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>

---------

Co-authored-by: Charlie Parker <charlie.parker@ideacrew.com>
Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
sri49 added a commit that referenced this pull request Dec 11, 2025
vFos2016 pushed a commit that referenced this pull request Dec 17, 2025
* Revert "loud cancel if previously published (#5804)"

This reverts commit 3641b97.

* Revert "modifies ATP outbound to exclude migrated FA applications (#5822)"

This reverts commit 988db6a.

* Revert "add error handling for individual with existing primary broker role (#5892)"

This reverts commit a1d8320.

* Revert "make time displayed consistent across evidence tables (#5930)"

This reverts commit 34cb662.

* Revert "fix disenroll member tool for prospective year (#5934)"

This reverts commit 70d91cf.

* persist country of citizenship in the UI (#5945)

* simplify country of citizenship retrieval

* fix country of citizenship field autopopulating

* rubocop fix

* CU-868gmnux2  :: Update workflow to auto build the image on the tags (#5944)

* fix disenroll member tool for prospective year (#5934)

* fix disenroll member tool for prospective year

* rubocop fixes

* raise error message

* change operation name

* rubocop fix

* remove the raise error if product is not found

* lint fix

* remove binding

* fix spec

* fix spec

* remove comment

* dry up enrollment methods

* fix method

---------

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants