Skip to content

Conversation

@sri49
Copy link
Contributor

@sri49 sri49 commented Dec 11, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868gn0ak4

A brief description of the changes:

Current behavior:

New behavior:

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@sri49 sri49 added the release *️⃣ Preparing a new release label Dec 11, 2025
@sri49 sri49 requested a review from a team as a code owner December 12, 2025 21:24
jacobkagon and others added 3 commits December 12, 2025 16:25
* simplify country of citizenship retrieval

* fix country of citizenship field autopopulating

* rubocop fix
* fix disenroll member tool for prospective year

* rubocop fixes

* raise error message

* change operation name

* rubocop fix

* remove the raise error if product is not found

* lint fix

* remove binding

* fix spec

* fix spec

* remove comment

* dry up enrollment methods

* fix method
Copy link
Contributor

@jacobkagon jacobkagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Reverts and adds the requested PRs.

@vFos2016 vFos2016 merged commit 9b68e8f into 31.5.x-release Dec 17, 2025
265 of 275 checks passed
@vFos2016 vFos2016 deleted the 31.5.0-pre-release branch December 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release *️⃣ Preparing a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants