fix disenroll member tool for prospective year #5934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/domain/operations/hbx_enrollments/drop_enrollment_members.rb
Outdated
Show resolved
Hide resolved
app/domain/operations/hbx_enrollments/drop_enrollment_members.rb
Outdated
Show resolved
Hide resolved
charlienparker
previously approved these changes
Dec 5, 2025
Contributor
charlienparker
left a comment
charlienparker
left a comment
There was a problem hiding this comment.
Nice job fixing this and DRYing up the cross walk operation. I have some nitpicks around DRYing up some HbxEnrollment functions but those aren't your responsibility at all. If you need to take this PR back for other reasons and think you have the time/it'd be worthwhile, consider those suggestions. I won't hold the PR up though - approved!
auto-merge was automatically disabled
December 5, 2025 14:45
Pull request was converted to draft
charlienparker
approved these changes
Dec 5, 2025
jacobkagon
deleted the
CU_868dqvuaw_fix_disenroll_member_tool_for_prospective_year
branch
sri49
pushed a commit
that referenced
this pull request
Dec 16, 2025
* fix disenroll member tool for prospective year * rubocop fixes * raise error message * change operation name * rubocop fix * remove the raise error if product is not found * lint fix * remove binding * fix spec * fix spec * remove comment * dry up enrollment methods * fix method
vFos2016
pushed a commit
that referenced
this pull request
Dec 17, 2025
* Revert "loud cancel if previously published (#5804)" This reverts commit 3641b97. * Revert "modifies ATP outbound to exclude migrated FA applications (#5822)" This reverts commit 988db6a. * Revert "add error handling for individual with existing primary broker role (#5892)" This reverts commit a1d8320. * Revert "make time displayed consistent across evidence tables (#5930)" This reverts commit 34cb662. * Revert "fix disenroll member tool for prospective year (#5934)" This reverts commit 70d91cf. * persist country of citizenship in the UI (#5945) * simplify country of citizenship retrieval * fix country of citizenship field autopopulating * rubocop fix * CU-868gmnux2 :: Update workflow to auto build the image on the tags (#5944) * fix disenroll member tool for prospective year (#5934) * fix disenroll member tool for prospective year * rubocop fixes * raise error message * change operation name * rubocop fix * remove the raise error if product is not found * lint fix * remove binding * fix spec * fix spec * remove comment * dry up enrollment methods * fix method --------- Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
lethelpers andbeforeblocks..html_safe.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket: https://app.clickup.com/t/868dqvuaw
A brief description of the changes:
Current behavior: Using the Disenroll Member tool for the prospective year, does not generate a prospective year product.
New behavior:
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.