Skip to content

Conversation

@jacobkagon
Copy link
Contributor

@jacobkagon jacobkagon commented Dec 9, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868ggdy5j

A brief description of the changes:

Current behavior: Country or origin is not persisting in the UI.

New behavior: Allow country of origin to persist in the UI when consumers move to edit via FAA

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@jacobkagon jacobkagon marked this pull request as draft December 9, 2025 21:52
@jacobkagon jacobkagon changed the title simplify country of citizenship retrieval persist country of origin in the UI Dec 9, 2025
@jacobkagon jacobkagon changed the title persist country of origin in the UI persist country of citizenship in the UI Dec 9, 2025
@jacobkagon jacobkagon marked this pull request as ready for review December 10, 2025 19:22
@jacobkagon jacobkagon assigned ATBull81 and unassigned ATBull81 Dec 10, 2025
@jacobkagon jacobkagon requested a review from ATBull81 December 10, 2025 19:22
@jacobkagon jacobkagon enabled auto-merge (squash) December 10, 2025 19:44
Copy link
Contributor

@ATBull81 ATBull81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for building form builder specs

Copy link
Contributor

@TristanB17 TristanB17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jacobkagon jacobkagon merged commit ad35799 into trunk Dec 10, 2025
265 of 276 checks passed
@jacobkagon jacobkagon deleted the CU_868ggdy5j_fix_country_of_origin_bug branch December 10, 2025 21:10
sri49 pushed a commit that referenced this pull request Dec 12, 2025
* simplify country of citizenship retrieval

* fix country of citizenship field autopopulating

* rubocop fix
sri49 pushed a commit that referenced this pull request Dec 12, 2025
* simplify country of citizenship retrieval

* fix country of citizenship field autopopulating

* rubocop fix
vFos2016 pushed a commit that referenced this pull request Dec 17, 2025
* Revert "loud cancel if previously published (#5804)"

This reverts commit 3641b97.

* Revert "modifies ATP outbound to exclude migrated FA applications (#5822)"

This reverts commit 988db6a.

* Revert "add error handling for individual with existing primary broker role (#5892)"

This reverts commit a1d8320.

* Revert "make time displayed consistent across evidence tables (#5930)"

This reverts commit 34cb662.

* Revert "fix disenroll member tool for prospective year (#5934)"

This reverts commit 70d91cf.

* persist country of citizenship in the UI (#5945)

* simplify country of citizenship retrieval

* fix country of citizenship field autopopulating

* rubocop fix

* CU-868gmnux2  :: Update workflow to auto build the image on the tags (#5944)

* fix disenroll member tool for prospective year (#5934)

* fix disenroll member tool for prospective year

* rubocop fixes

* raise error message

* change operation name

* rubocop fix

* remove the raise error if product is not found

* lint fix

* remove binding

* fix spec

* fix spec

* remove comment

* dry up enrollment methods

* fix method

---------

Co-authored-by: Jacob Kagon <69021620+jacobkagon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants