MNT: auto-upgrade pre-commit hooks #278
Conversation
|
ok actually the problem is twofold: update: this is #279 |
neutrinoceros
force-pushed
the
mnt/auto-upgrade-pre-commit-hooks
branch
2 times, most recently
from
7521358 to
59be428
Compare
|
Rebased on top of #281.
Now that I got things sorted out, I should clarify this wasn't quite correct: pre-commit 4.0 doesn't break the existing configuration, but updating |
neutrinoceros
force-pushed
the
mnt/auto-upgrade-pre-commit-hooks
branch
from
59be428 to
b507fc7
Compare
|
and rebased again, this time on the target branch |
## [2.1.02] 2024-10-24 ### Changed - Fix a bug that could lead to corrupted VTK file when using single precision arithmetic (#255) - Fix a bug that could lead to incorrect central mass gravitational potential upon restart (#287) - Changed the way magnetic field is reconstructed when using grid coarsening to reduce roundoff errors on div(B). This can have an impact on the results of models using grid coarsening+MHD (#284) - Ensure that XDMF outputs are precision agnostic (#261) - Bump up Kokkos version to 4.4.01 (#289) - Check that writes are successfull in serial, otherwise throw an error (#260) - Ensure that shock flattening flags can be modified by user (#260) - Throw an error when user enables Fargo without enough DIMENSIONS (#250) - Fix linting errors following upgrade to cpplint 2.0 (#278, #279, #281) - Update idfx_io to numpy 2.0 (#283) ### Added - Allow the user to define the grid and boundary conditions only on active dimensions (#274) - Configuration for Nvidia H100 on Jean Zay in the documentation --------- Co-authored-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr> Co-authored-by: vdbma <93188557+vdbma@users.noreply.github.com> Co-authored-by: Marc Van den Bossche <marc.vanden-bossche@univ-grenoble-alpes.fr> Co-authored-by: Alankar Dutta <dutta.alankar@gmail.com> Co-authored-by: Alankar Dutta <alankard@MB-167.local> Co-authored-by: ThomasJannaudCAM <159052976+ThomasJannaudCAM@users.noreply.github.com> Co-authored-by: Clément Robert <cr52@protonmail.com> Co-authored-by: marc <vandenbossche.marc@hotmail.com> Co-authored-by: Antonin Borderies <89980449+Anto6453@users.noreply.github.com>
2 participants
This doesn't fix the on-going CI issue with
pre-commit/actionfailing systematically but it'll help as a first step:some hooks used here are outdated and incompatible with pre-commit 4.0 (which I'm betting is causing the failure).
cpplintfromhttps://gitlab.com/daverona/pre-commit/cpphowever hasn't been updated for 4 years so it's not that surprising that it's broken now, but I'll try to find a solution for that one too.