Reduce roundoff error on div(B) when using grid coarsening #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
glesur
added a commit
that referenced
this pull request
Oct 24, 2024
## [2.1.02] 2024-10-24 ### Changed - Fix a bug that could lead to corrupted VTK file when using single precision arithmetic (#255) - Fix a bug that could lead to incorrect central mass gravitational potential upon restart (#287) - Changed the way magnetic field is reconstructed when using grid coarsening to reduce roundoff errors on div(B). This can have an impact on the results of models using grid coarsening+MHD (#284) - Ensure that XDMF outputs are precision agnostic (#261) - Bump up Kokkos version to 4.4.01 (#289) - Check that writes are successfull in serial, otherwise throw an error (#260) - Ensure that shock flattening flags can be modified by user (#260) - Throw an error when user enables Fargo without enough DIMENSIONS (#250) - Fix linting errors following upgrade to cpplint 2.0 (#278, #279, #281) - Update idfx_io to numpy 2.0 (#283) ### Added - Allow the user to define the grid and boundary conditions only on active dimensions (#274) - Configuration for Nvidia H100 on Jean Zay in the documentation --------- Co-authored-by: Nicolas Aunai <nicolas.aunai@lpp.polytechnique.fr> Co-authored-by: vdbma <93188557+vdbma@users.noreply.github.com> Co-authored-by: Marc Van den Bossche <marc.vanden-bossche@univ-grenoble-alpes.fr> Co-authored-by: Alankar Dutta <dutta.alankar@gmail.com> Co-authored-by: Alankar Dutta <alankard@MB-167.local> Co-authored-by: ThomasJannaudCAM <159052976+ThomasJannaudCAM@users.noreply.github.com> Co-authored-by: Clément Robert <cr52@protonmail.com> Co-authored-by: marc <vandenbossche.marc@hotmail.com> Co-authored-by: Antonin Borderies <89980449+Anto6453@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original procedure for the field reconstruction for grid coarsening led to possibly significant roundoff errors when the grid coarsening level was larger than 3-4. This PR fixes this issue, using a more robust reconstruction from both the left and right side of the grid coarsening pencil (previous reconstruction was from the left side only).