Fix contacts array when creating or updating client#67
Merged
Conversation
abreckner
approved these changes
Sep 6, 2021
Contributor
abreckner
left a comment
There was a problem hiding this comment.
Ah interesting. I did not know that...
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fix contacts array when creating or updating client * Fix specs
lankz
pushed a commit
that referenced
this pull request
Jun 10, 2025
* Fix contacts array when creating or updating client * Fix specs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XPM API expects xml of the form
inside a Client for creating contacts when updating. The code appeared to specify this, but actually
.to_xmlon a Hash works differently to expected, where an array type calledContactswill automatically have each entry wrapped withContact. So the generated XML was looking likeWhich meant it didn't work. This was only for creating contacts during client creation, which I gather nobody had used before.