Skip to content

Fix contacts array when creating or updating client #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mehwoot merged 2 commits into from
Sep 6, 2021
Merged

Fix contacts array when creating or updating client #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e4e8c
Fix contacts array when creating or updating client
mehwoot Sep 6, 2021
1507525
Fix specs
mehwoot Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions lib/xpm_ruby/schema/client/add.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,14 @@ module Client
AccountManagerID?: Types::String,
Contacts?: Types::Array.of(
Types::Hash.schema(
Contact: Types::Hash.schema(
Name: Types::String,
IsPrimary?: Types::String,
Salutation?: Types::String,
Addressee?: Types::String,
Phone?: Types::Coercible::String,
Mobile?: Types::Coercible::String,
Email?: Types::String,
Position?: Types::String
).with_key_transform(&:to_sym)
Name: Types::String,
IsPrimary?: Types::String,
Salutation?: Types::String,
Addressee?: Types::String,
Phone?: Types::Coercible::String,
Mobile?: Types::Coercible::String,
Email?: Types::String,
Position?: Types::String
).with_key_transform(&:to_sym)
),
BillingClientID?: Types::Coercible::String,
Expand Down
18 changes: 8 additions & 10 deletions lib/xpm_ruby/schema/client/update.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,14 @@ module Client
AccountManagerID?: Types::String,
Contacts?: Types::Array.of(
Types::Hash.schema(
Contact: Types::Hash.schema(
Name: Types::String,
IsPrimary?: Types::String,
Salutation?: Types::String,
Addressee?: Types::String,
Phone?: Types::Coercible::String,
Mobile?: Types::Coercible::String,
Email?: Types::String,
Position?: Types::String
).with_key_transform(&:to_sym)
Name: Types::String,
IsPrimary?: Types::String,
Salutation?: Types::String,
Addressee?: Types::String,
Phone?: Types::Coercible::String,
Mobile?: Types::Coercible::String,
Email?: Types::String,
Position?: Types::String
).with_key_transform(&:to_sym)
),
BillingClientID?: Types::Coercible::String,
Expand Down
4 changes: 2 additions & 2 deletions spec/xpm_ruby/schema/client/add_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Schema
context "with a valid Add schema" do
context "with contacts" do
it "should not raise an error" do
hash = { "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Contact" => { "Name" => "Joe Bloggs" } }] }
hash = { "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Name" => "Joe Bloggs" }] }
expect { Client::Add[hash] }.not_to raise_error
end
end
Expand All @@ -32,7 +32,7 @@ module Schema
end

it "should raise an error on contacts" do
hash = { "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Contact" => { "Email" => "Joe Bloggs" } }] }
hash = { "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Email" => "Joe Bloggs" }] }
expect { Client::Add[hash] }.to raise_error(Dry::Types::SchemaError, /Name is missing in Hash input/)
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/xpm_ruby/schema/client/update_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Schema
context "with a valid Update schema" do
context "with contacts" do
it "should not raise an error" do
hash = { "ID" => 25655881, "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Contact" => { "Name" => "Joe Bloggs" } }] }
hash = { "ID" => 25655881, "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Name" => "Joe Bloggs" }] }
expect { Client::Update[hash] }.not_to raise_error
end
end
Expand All @@ -32,7 +32,7 @@ module Schema
end

it "should raise an error on contacts" do
hash = { "ID" => 25655881, "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Contact" => { "Email" => "Joe Bloggs" } }] }
hash = { "ID" => 25655881, "Name" => "Joe Bloggs Consulting", "Contacts" => [{ "Email" => "Joe Bloggs" }] }
expect { Client::Update[hash] }.to raise_error(Dry::Types::SchemaError, /Name is missing in Hash input/)
end
end
Expand Down