fix: get_edge_ids() error for 2x2 matrices#1798
Conversation
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
|
I see that only three packages are affected: corpustools, mwcsr and SEMID. One of the results also hints at a misuse from igraph itself. I still think we should break cleanly and perhaps improve the error message. |
|
Another alternative: disallow matrices altogether, ask users to convert matrices with |
|
Fine by me, lets find a way in this PR |
get_edge_ids() throws warning instead of error for 2x2 matricesget_edge_ids() error for 2x2 matrices
|
Let's await revdepchecks in #1793. |
|
Run revdepchecks on main again, then here. |
|
@krlmlr friendly reminder to run revdeps 😸 |
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
|
Let's ask the downstream maintainers to adapt. |
|
PRs send to the 3 packages. Should we close this PR then? |
|
Closing, let downstream break. |
The function now throws a warning and indicates how the matrix is interpreted for backward compatibility