Skip to content

fix: get_edge_ids() error for 2x2 matrices#1798

Closed
schochastics wants to merge 6 commits intomainfrom
get-edge-ids-warn
Closed

fix: get_edge_ids() error for 2x2 matrices#1798
schochastics wants to merge 6 commits intomainfrom
get-edge-ids-warn

Conversation

@schochastics
Copy link
Copy Markdown
Contributor

The function now throws a warning and indicates how the matrix is interpreted for backward compatibility

@aviator-app
Copy link
Copy Markdown
Contributor

aviator-app Bot commented Apr 4, 2025

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@schochastics schochastics requested a review from krlmlr April 4, 2025 15:38
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Apr 4, 2025

I see that only three packages are affected: corpustools, mwcsr and SEMID. One of the results also hints at a misuse from igraph itself. I still think we should break cleanly and perhaps improve the error message.

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Apr 4, 2025

Another alternative: disallow matrices altogether, ask users to convert matrices with c() or to pass data frames if they have data in columns.

@schochastics
Copy link
Copy Markdown
Contributor Author

Fine by me, lets find a way in this PR

@schochastics schochastics changed the title fix: get_edge_ids() throws warning instead of error for 2x2 matrices fix: get_edge_ids() error for 2x2 matrices Apr 4, 2025
@schochastics schochastics marked this pull request as draft April 5, 2025 17:46
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Apr 10, 2025

Let's await revdepchecks in #1793.

Comment thread R/interface.R Outdated
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jun 5, 2025

Run revdepchecks on main again, then here.

@maelle
Copy link
Copy Markdown
Contributor

maelle commented Jun 10, 2025

@krlmlr friendly reminder to run revdeps 😸

@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jul 3, 2025

Let's ask the downstream maintainers to adapt.

@schochastics
Copy link
Copy Markdown
Contributor Author

PRs send to the 3 packages. Should we close this PR then?

@schochastics schochastics added this to the 2.2.0 milestone Jul 8, 2025
@krlmlr
Copy link
Copy Markdown
Contributor

krlmlr commented Jul 10, 2025

Closing, let downstream break.

@krlmlr krlmlr closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants