WIP: fix: Avoid storing attributes in global preserve list#869
Closed
WIP: fix: Avoid storing attributes in global preserve list#869
Conversation
Contributor
Author
|
Closing in favor of #870. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation seems to call
R_PreserveObject()andR_ReleaseObject()way too often. This is R's global "preserve" list of objects that are never freed.With the new implementation, we only add to the global list directly after initializing the attributes. As soon as we return the constructed object as an
SEXPto R, the attributes are removed from the global preserve list.The only problem I see is if we initialize the attributes and then exit with an error. The attribute vector will remain in the global preserve list forever, a memory leak. In fact, we should not use the global preserve list for that, but maintain or own list that we free unconditionally when returning to R.
This is only possible because we now check all igraph function calls and don't longjmp.