fix: Change ownership rules of attribute objects#870
Merged
Antonov548 merged 7 commits intomainfrom Jul 3, 2023
Merged
Conversation
This was referenced Jul 2, 2023
chore:
R_SEXP_to_igraph() and R_SEXP_to_igraph_copy() get igraph_t object from external pointer
#865
Merged
krlmlr
force-pushed
the
f-866-un-preserve-2
branch
3 times, most recently
from
c5c6a78 to
82fb03a
Compare
krlmlr
force-pushed
the
f-866-un-preserve-2
branch
from
82fb03a to
c68b9be
Compare
Antonov548
approved these changes
Jul 3, 2023
Contributor
Author
|
Thanks! This was quick, we can still do a detailed review, commit by commit, after the fact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a global preserve list to which attribute objects can be added while no corresponding R graph object exists. This list is cleared before the next call to an igraph function.
This will only leak memory if a single igraph function call initializes attributes many times without actually using them, and only before a second igraph function call is made.
The commits can be reviewed individually.
Closes #866.