Skip to content

fix: Change ownership rules of attribute objects #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antonov548 merged 7 commits into from
Jul 3, 2023
Merged

fix: Change ownership rules of attribute objects #870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5bc6504
Add tests
krlmlr Jul 2, 2023
c3b532e
Maintain own temporary preserve list
krlmlr Jul 2, 2023
a3f07e9
Call R_igraph_attribute_clean_preserve_list() first
krlmlr Jul 2, 2023
5397bca
Avoid R_igraph_attribute_protected
krlmlr Jul 2, 2023
2faccd9
Remove R_igraph_attribute_protected
krlmlr Jul 2, 2023
56fca59
Avoid reference counting
krlmlr Jul 2, 2023
c68b9be
Breaking: Remove reference counting
krlmlr Jul 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rinterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,15 @@

SEXP R_igraph_add_env(SEXP graph);

void R_igraph_attribute_clean_preserve_list();
void R_igraph_set_in_r_check(bool set);
void R_igraph_error(void);
void R_igraph_warning(void);
void R_igraph_interrupt(void);

#define IGRAPH_R_CHECK(func) \
do { \
R_igraph_attribute_clean_preserve_list(); \
R_igraph_set_in_r_check(true); \
igraph_error_type_t __c = func; \
R_igraph_set_in_r_check(false); \
Expand Down
Loading