Closed
Conversation
edited tables for solar to minimize confusion (renewable.rst) added description of SM1 and SM3 (electricity.rst) added separate lines for SM1 and SM3 in the technology table (electricity.rst)
khaeru
approved these changes
Oct 7, 2019
Member
khaeru
left a comment
khaeru
left a comment
There was a problem hiding this comment.
These look good to me, but another colleague will check more closely.
Contributor
|
Hi @Jihoon , However, I can see that you chose to commit to the Could you switch this PR to the branch I'll get back to you once I've checked both files 😃 Cheers |
Contributor
|
Hi @Jihoon , Everything looks fine to me! I think we can close this PR and merge it! |
Contributor
Author
|
Replace this with #33 (corrected branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edited table formats for solar PV and CSP to reduce confusion (renewable.rst)
added description of SM1 and SM3 (electricity.rst)
added separate lines for SM1 and SM3 in the technology table (electricity.rst)