Suggested changes for sections: energy demand & tech change - correct branch#34
Merged
jkikstra merged 3 commits intoiiasa:2019-updatefrom Oct 15, 2019
Merged
Suggested changes for sections: energy demand & tech change - correct branch#34jkikstra merged 3 commits intoiiasa:2019-updatefrom
jkikstra merged 3 commits intoiiasa:2019-updatefrom
Conversation
Minor edits and improvements In tech change section, it would be helpful to add remarks on how in general diffusion constraints are determined for different technologies or what the values are based on. In energy demand section, frequent uses of 'several' sound too ambiguous.
Contributor
|
Wonderful @Jihoon ! thank you! Let's then close this PR and merge it to the |
Contributor
Jihoon
changed the title
Contributor
Author
|
@francescolovat, I closed it and replaced it with #33. |
Contributor
|
Oh yes now I see @Jihoon ! Cool! I hope we can close and merge both soon 😃 |
jkikstra
approved these changes
Oct 9, 2019
Contributor
jkikstra
left a comment
jkikstra
left a comment
There was a problem hiding this comment.
Great, thanks for making the changes! I don't have any other concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #31, but to the correct branch.