Suggested changes for sections: energy demand & tech change#31
Closed
Jihoon wants to merge 3 commits intoiiasa:masterfrom
Closed
Suggested changes for sections: energy demand & tech change#31Jihoon wants to merge 3 commits intoiiasa:masterfrom
Jihoon wants to merge 3 commits intoiiasa:masterfrom
Conversation
Minor edits and improvements In tech change section, it would be helpful to add remarks on how in general diffusion constraints are determined for different technologies or what the values are based on. In energy demand section, frequent uses of 'several' sound too ambiguous.
Contributor
Author
|
For 'Energy demand':
|
Contributor
|
@Jihoon I was assigned to check up on this PR. A few comments: I very much like the textual changes in the documentation, it is much clearer now. Things that should be changed:
Minor textual points that could be considered:
As there is no-one besides yourself assigned to review these changes (see assigned reviewers), it's up to you to decide whether someone else should still look at this before committing to the |
jkikstra
requested changes
Oct 8, 2019
Contributor
jkikstra
left a comment
jkikstra
left a comment
There was a problem hiding this comment.
merge into 2019-update branch rather than master
jkikstra
reviewed
Oct 8, 2019
|
|
||
| .. _tab-quantssp1: | ||
| .. table:: Convergence quantile and income for each parameter and region for SSP1 (for region descriptions, see: :ref:`spatial`) | ||
| .. table:: Convergence quantile and income for each variable and region for SSP1 (for region descriptions, see: :ref:`spatial`) |
jkikstra
reviewed
Oct 9, 2019
| while still reducing the flip-flop behavior and sudden penetration of technologies. | ||
|
|
||
| :numref:`fig-difconstraint` below illustrates the maximum technology growth starting at a level of 1 in year t=0 for a set of five diffusion constraints which jointly lead to a soft constraint. | ||
| :numref:`fig-difconstraint` below illustrates the maximum technology growth starting at a level of 1 in year *t*=0 for a set of five diffusion constraints which jointly lead to a soft constraint. |
Contributor
Author
|
replaced with #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor edits and improvements
In technological change section, it would be helpful to add remarks on how general diffusion constraints are determined for different technologies or what the values are based on.