Allow byte literals in TryFromPrimitive alternatives#181
Merged
illicitonion merged 1 commit intoillicitonion:mainfrom Mar 15, 2026
Merged
Allow byte literals in TryFromPrimitive alternatives#181illicitonion merged 1 commit intoillicitonion:mainfrom
illicitonion merged 1 commit intoillicitonion:mainfrom
Conversation
Owner
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Thanks for the contribution, I think it makes a lot of sense.
Please can you add a test to https://github.com/illicitonion/num_enum/blob/main/num_enum/tests/try_from_primitive.rs showing this works?
Also if you merge main / rebase the failing existing test should start passing again :)
Thanks!
Contributor
Author
|
Oh whoops, I added a test but I guess I forgot to push. |
coolreader18
force-pushed
the
byte-alternative
branch
from
1e33bbd to
8fc3b30
Compare
Owner
|
Released as 0.7.6 - thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for when the values correspond to ascii codepoints, it's more self-explanatory to put
b'A'than0x41.