Skip to content

Allow byte literals in TryFromPrimitive alternatives #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
illicitonion merged 1 commit into from
Mar 15, 2026
+14 −10
Merged

Allow byte literals in TryFromPrimitive alternatives #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion num_enum/tests/try_from_primitive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ fn alternative_values() {
#[repr(i8)]
enum Enum {
Zero = 0,
#[num_enum(alternatives = [-1, 2, 3])]
#[num_enum(alternatives = [-1, 2, b'\x03'])]
OneTwoThreeOrMinusOne = 1,
}

Expand Down
22 changes: 13 additions & 9 deletions num_enum_derive/src/parsing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,16 +429,20 @@ fn parse_discriminant(val_exp: &Expr) -> Result<DiscriminantValue> {
unsigned_expr = expr;
sign = -1;
}
if let Expr::Lit(ExprLit {
lit: Lit::Int(ref lit_int),
..
}) = unsigned_expr
{
Ok(DiscriminantValue::Literal(
match unsigned_expr {
Expr::Lit(ExprLit {
lit: Lit::Int(lit_int),
..
}) => Ok(DiscriminantValue::Literal(
sign * lit_int.base10_parse::<i128>()?,
))
} else {
Ok(DiscriminantValue::Expr(val_exp.clone()))
)),
Expr::Lit(ExprLit {
lit: Lit::Byte(lit_byte),
..
}) => Ok(DiscriminantValue::Literal(
sign * i128::from(lit_byte.value()),
)),
_ => Ok(DiscriminantValue::Expr(val_exp.clone())),
}
}

Expand Down
Loading