Conversation
3841550 to
8782941
Compare
|
Currently this is blocked, because a toolchain update is needed for the stabilised I have checked whether |
efbe9b7 to
1bc262b
Compare
1bc262b to
00f9b03
Compare
app-libs/stf/src/lib.rs
Outdated
| StorageHashMismatch, | ||
| InvalidStorageDiff, | ||
| } | ||
| #[allow(clippy::large_enum_variant)] |
There was a problem hiding this comment.
If the clippy lint large_enum_variant should be suppressed let me know and I will drop the patch for it.
clangenb
left a comment
There was a problem hiding this comment.
One remark, otherwise it looks good!
cli/Cargo.toml
Outdated
| my-node-runtime = { package = "integritee-node-runtime", git = "https://github.com/integritee-network/integritee-node.git", branch = "szp/polkadot-v0.9.29" } | ||
| pallet-evm = { optional = true, git = "https://github.com/integritee-network/frontier.git", branch = "polkadot-v0.9.29" } | ||
| substrate-api-client = { features = ["ws-client"], git = "https://github.com/scs/substrate-api-client.git", branch = "polkadot-v0.9.29" } | ||
| substrate-client-keystore = { git = "https://github.com/scs/substrate-api-client.git", branch = "polkadot-v0.9.29" } | ||
| teerex-primitives = { git = "https://github.com/integritee-network/pallets.git", branch = "szp/polkadot-v0.9.29" } |
There was a problem hiding this comment.
here, we still need to update the branch afterwards
47a270f to
d6d6697
Compare
clangenb
left a comment
There was a problem hiding this comment.
Nice, looks good to me. I have only one remark!
| let mut params = CertificateParams::new(vec![common_name.to_string()]); | ||
| let now = SystemTime::now().duration_since(UNIX_EPOCH).expect("Error: UNIX_EPOCH"); | ||
| let issue_ts = TzUtc.timestamp(now.as_secs() as i64, 0); | ||
| let issue_ts = TzUtc.timestamp_opt(now.as_secs() as i64, 0).unwrap(); |
There was a problem hiding this comment.
If you know some context about the None here, I would prefer an expect. If it is something that never fails in our case, it is even better, and you can write like: expect("fails never because of ....; qed).
If it can fail, I would prefer to actually return a result here.
There was a problem hiding this comment.
This should not fail as long as now.as_secs() (aka secs) fit into i64. The as keyword will silently convert it into -1 (e.g. when secs == u64::MAX) and that's when it would fail.
Revised in 89e7ac2.
…tamp()` function
… `timestamp()` function
… `timestamp()` function
clangenb
left a comment
There was a problem hiding this comment.
The great merge has arrived!
Fixes #1021