Merged
Conversation
…gx flag anymore. It is defined by the target_arch
…eed of sgx flag anymore. It is defined by the target_arch". Sgx conditional compilation seems to be more involed than i thought. This needs proper thinking changing this. This reverts commit 8d0400c
murerfel
reviewed
Jun 29, 2021
Contributor
murerfel
left a comment
murerfel
left a comment
There was a problem hiding this comment.
Looks good to me. Quite a few questions from my side to help my understanding of the code, hope you can forgive that 😉
The one minor change I'd make, is the test comparing an entire response JSON string, using contains() instead
murerfel
approved these changes
Jun 30, 2021
brenzi
approved these changes
Jun 30, 2021
Collaborator
brenzi
left a comment
brenzi
left a comment
There was a problem hiding this comment.
this is 95% refactoring and 5% on-topic
too big for me to review in detail. but I get you can broadcast blocks and receive them (without applying them yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poc of block broadcasting: Closes #244. It is only a PoC, as the workers simply broadcast blocks. There is no scheduling (aura) and received blocks by other workers are only logged to the command line without applying the state diff.
Major:
enclave-apicrate. PoC on how we can abstract the interface to the enclave.Workerstruct. PoC on how we could abstract every aspect of the worker's features.ws-serverthe worker listens for direct requests. It comes from the jsonrpsee crate - the rpc abstraction that will be successor to the current implementation in substrate. It currently coexists with the old direct_server, but I think we should replace the old one soon. It removes a lot of boilerplate code and is async. Since the introduction of theasync/awaitsyntax in rust, I believe we should go async, as it is much less verbose in general.Stf::apply_statediff()it is unit tested but not yet integrated in the enclave.Minor:
direct_clientthat actually reflects the functionality.