Conversation
murerfel
approved these changes
Jul 14, 2021
Contributor
murerfel
left a comment
murerfel
left a comment
There was a problem hiding this comment.
So this increases the number of threads that can be run simultaneously inside the enclave?
Contributor
Author
|
Yes, from the logs we saw that jenkins fails due to no more trusted threads available. The reason that this has suddendly become an issue is (I assume) that we have now the hybrid version with the async and sync worker-rpc-server, introduced in #277, which can launch more simultaneous enclave threads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases the amount of trusted threads that can be launched, and should fix the jenkins CI.
I do this now, as I don't exactly know, how long it takes to finish GitHub actions CI.
When jenkins is happy again, we can start merging all the PRs.
Closes: #304