Skip to content

audit F20 [robustness]: swallowed create_ephemeral_channel Result in member-list temp-channel button #620

@intendednull

Description

@intendednull

File: crates/web/src/components/member_list.rs:384
Severity: robustness
Obvious? yes

The "start temp channel…" button calls h.create_ephemeral_channel(&name, EphemeralKind::Channel, DEFAULT_CHANNEL_THRESHOLD_MS).await inside spawn_local, then discards the Result with let _ =. If the mutation fails (network not connected, lacking permission, name collision), the user sees no feedback and no log line is emitted. Same pattern PR #585 fixed for handle_ice_candidate.

Fix: bind the return, log via tracing::warn! on Err, and surface a toast or fall back to the existing failure UI helper used elsewhere in this component.


Filed by /general-audit @ 88498a5 (2026-05-04). master: #600.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions