fix: gate test_config behind cfg(test), guard profile keydown listener#395
Merged
Conversation
#331: WorkerConfig::test_config() was pub in the production module with no cfg gate. Test artifact now only compiled in test builds. #347: Profile keydown Escape listener fired unconditionally on every keydown event site-wide. Guard now checks is_some before clearing, so it only acts when a profile card is actually open. https://claude.ai/code/session_01HzWjHTaoQ8EJ64foWr3Zv4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes from audit.
#331 TD-13 — test_config() live in prod module. Gate with #[cfg(test)]. Test artifact not reachable from release builds.
#347 GEN-04 — profile keydown listener fire Escape even when no profile open. Guard with is_some check. Prevents racing other Esc handlers.
Closes #331, closes #347
Generated by Claude Code