Skip to content

fix: gate test_config behind cfg(test), guard profile keydown listener #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intendednull merged 1 commit into from
Apr 26, 2026
Merged

fix: gate test_config behind cfg(test), guard profile keydown listener #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/web/src/profile/controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ pub fn use_profile_controller() -> (
let write = use_context::<crate::state::AppWriteSignals>().expect("AppWriteSignals in context");
let read_sig = app_state.profile.open;
let write_sig = write.profile.set_open;
install_listeners_once(write_sig);
install_listeners_once(read_sig, write_sig);
(read_sig, write_sig)
}

Expand All @@ -55,7 +55,10 @@ pub fn use_profile_controller() -> (
/// Idempotent — the helper tags `<body data-profile-bus="mounted">`
/// so repeat calls are no-ops. In practice the root `<App>` calls
/// [`use_profile_controller`] once, which calls this helper once.
fn install_listeners_once(set_open: WriteSignal<Option<ProfileState>>) {
fn install_listeners_once(
open: ReadSignal<Option<ProfileState>>,
set_open: WriteSignal<Option<ProfileState>>,
) {
let Some(win) = web_sys::window() else { return };
let body = match win.document().and_then(|d| d.body()) {
Some(b) => b,
Expand Down Expand Up @@ -110,10 +113,10 @@ fn install_listeners_once(set_open: WriteSignal<Option<ProfileState>>) {
.ok();
on_close.forget();

// ESCAPE — close on Escape anywhere.
// ESCAPE — close on Escape, but only when a profile is actually open.
let on_esc = Closure::<dyn FnMut(web_sys::Event)>::new(move |ev: web_sys::Event| {
if let Ok(ke) = ev.dyn_into::<web_sys::KeyboardEvent>() {
if ke.key() == "Escape" {
if ke.key() == "Escape" && open.with(Option::is_some) {
set_open.set(None);
}
}
Expand Down
1 change: 1 addition & 0 deletions crates/worker/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ pub struct WorkerConfig {

impl WorkerConfig {
/// Create a config for testing.
#[cfg(test)]
pub fn test_config() -> Self {
Self {
identity_path: "/tmp/test-worker.key".to_string(),
Expand Down