chore(workers): platform-aware default paths#439
Merged
intendednull merged 1 commit intoApr 27, 2026
Conversation
Replace hardcoded `/etc/willow/*.key` and `/var/lib/willow/storage.db` clap defaults in replay + storage bins with dirs::config_dir() / dirs::data_dir() lookups, falling back to historical Linux paths when no XDG dir resolves. Behaviour unchanged when --identity-path or --db-path passed (e.g. Docker images). Refs #324
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hardcoded
/etc/willow/*.key+/var/lib/willow/storage.dbin clapdefault_valueflags. Linux-only. Bad on macOS/Windows dev. TD-06.What
default_replay_key()incrates/replay/src/main.rs. Usedirs::config_dir(). Fallback/etc/willow/replay.key.default_storage_key()+default_storage_db()incrates/storage/src/main.rs. Usedirs::config_dir()for key,dirs::data_dir()for db. Fallback to historical Linux paths.default_value_t = helper().display().to_string(). Behaviour unchanged when flag passed (Docker images set own paths).willow/<file>, parent dir name =willow, path absolute.Scope guard
default_value = "/..."sites./tmp/test-worker.keystruct-field default left alone (TD-13).Verify
Refs #324
Generated by Claude Code