docs(web): SAFETY comment for DerivedStateActor#445
Merged
intendednull merged 1 commit intoApr 27, 2026
Merged
Conversation
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Audit AUD-1: bare
unsafe impl SendonDerivedStateActorno SAFETY comment. Future maintainer no clue if impl redundant or load-bearing.Fix
// SAFETY:block aboveunsafe impl Sendincrates/web/src/state_bridge.rs.StateRef<T>Send via params,Arc<dyn Fn ... + Send + Sync>Send via trait-object bound,Arc<Mutex<Option<U>>>Send via params,SendWrapper<WriteSignal<U>>unconditional Send w/ runtime cross-thread panic.docs/specs/2026-04-26-state-management-model-design.md) sincecachedMutex tracked there.!Sendfield forces reaffirmation.Verify
cargo fmtcleancargo clippy --workspace --all-targets -- -D warningscleancargo test --workspaceall passcargo check --target wasm32-unknown-unknownclean for all WASM cratesRefs #435
Generated by Claude Code