feat: expo plugin#155
Conversation
|
@Br1an-Boyle, hello! |
|
Hi, |
|
Yes, please consider this. Expo support would be very useful. |
|
@Br1an-Boyle @uddish @looskie is it possible to look over and merge this PR? |
|
Hi, PS : @erwanlpfr , meanwhile, is it possible to add the support for push notifications so the plugin will be almost complete when this PR will be merged ? |
|
Hey folks 👋 |
Co-authored-by: Uddish Verma <uddish.verma@intercom.io>
|
Wow this is Christmas 😀 |
|
Hey @yonitou For the notifications support, I would suggest opening a PR for now 😄 |
|
@uddish what is the minimum version of |
|
Great to see this merged. Thanks! To use EU hosting do we need to change both the and the ? |
|
Is the config plugin name Usually the convention is the use the package name inside the package.json file. I'm getting the following error from Expo when trying to build:
|
|
It does not work for me either. When I tried with: [
'@intercom/intercom-react-native',
{
appId: 'our-id',I got the following error: Partial fix in #161 maybe someone else can figure out the rest? |
|
And the README import fix #162 |
|
@ottob I get the same issue using |
|
I missed that point ! |
|
Hey folks |
|
Excited for this all to get working! Does anyone know if push notifications are currently being worked on? |
* feat: expo plugin * fix: export usage * chore: use correct wording for Australia Co-authored-by: Uddish Verma <uddish.verma@intercom.io> --------- Co-authored-by: Uddish Verma <uddish.verma@intercom.io>
|
@uddish any chances of getting back on the comments, most importantly notifications? We are very reliant on notifications and the previous version of your SDK has a couple of memory-leaks and on specifically on Android we noticed issues with the real-time-ness of messages. all of them seem to be fixed in the latest SDK but without notifications we can't upgrade and it's causing us quite a bit of trouble. |
I made a quick plugin to add support for iOS notifications: https://gist.github.com/brkastner/fc3339faf623201ef6e2945afae525ec |
|
@brkastner Would you be open to add this gist in a PR on the repo ? So at least it would be a starting point for someone else to complete it with the Android part ? |
|
Coming back here after one month. @uddish, is it possible to plan the push notifications support ? Without it, a lot of us can't upgrade without losing the feature .. Some news would be great |
Hello,
After a while I was looking for an
expo pluginfor intercom.It turns out that existing projects are maintained by the community.
The last up to date is expo/config-plugins#208 suggested by @enagorny.
As you can see in this discussion, an expo maintainer suggested creating a PR to have more visibility in your project.
(Would be nice to have an issue tab here)
So, I give full credit of this work to @enagorny and community for this code.
I added the needed package and the related code.
This code is in a safer place here since it is supposed to follow the native code.
Let me know if it works for you, intercom team and for the others!