fix expo config plugin

[ottob]

But there is still an error:

Error: Cannot find module '../../package.json'
Require stack:
- /myproject/node_modules/@intercom/intercom-react-native/lib/commonjs/expo-plugins/index.js

since

intercom-react-native/src/expo-plugins/index.ts

Line 19 in f75b38c

import packageJson from '../../package.json';

should be

import packageJson from '../../../package.json';

because after the build the file ends up in /lib/commonjs/expo-plugins/index.js so it needs to step back three folders.
not sure how to fix that...

[ansh]

Yeah this is broken and should be merged ASAP @uddish

[tomfinney]

the only way i can think to make this work (quickly...) is to just completely remove importing the package.json from inside of the expo plugins file.

import packageJson from '../../package.json';

we just can't have a relative import like that if src/expo-plugins/index.ts is going to end up nested in another directory

so, my great suggestion would be to just remove import package.json there, at the bottom of the expo-plugins/index.ts file, change it to be like

const thing = (pkg) => createRunOncePlugin(
  withIntercomReactNative,
  pkg.name,
  pkg.version
);

export default thing

then in side of the app.plugin.js file, we import the package json inside of there and pass the stuff along like

const packageJson = require('./package.json');

const pkg = {
  // Prevent this plugin from being run more than once.
  // This pattern enables users to safely migrate off of this
  // out-of-tree `@config-plugins/intercom-react-native` to a future
  // upstream plugin in `intercom-react-native`
  name: packageJson.name,
  // Indicates that this plugin is dangerously linked to a module,
  // and might not work with the latest version of that module.
  version: packageJson.version,
};

const plugin = require('./lib/commonjs/expo-plugins');

module.exports = plugin.default(pkg);

[ottob]

the only way i can think to make this work (quickly...) is to just completely remove importing the package.json from inside of the expo plugins file.

Thanks, this sounds like a good solution. I tried to push commits for this now.

[tomfinney]

the only way i can think to make this work (quickly...) is to just completely remove importing the package.json from inside of the expo plugins file.

Thanks, this sounds like a good solution. I tried to push commits for this now.

👏

seems alright to me

there's probably a less dumb way of doing it but the app.plugin.js file itself referring to a lib/commonjs file that only exists after being built makes it a bit tricky... 🤷

[renatoalvesmh]

Could we merge it ? im having issues with sdk 50

[renatoalvesmh]

@ottob seems is failing on lint step in CI
just an small fix, would be possible to merge it ?
We are having issues in our company with new version would be amazing if its could be merged

[ottob]

just an small fix, would be possible to merge it ?

fixed the lint issue now

[renatoalvesmh]

@ottob thank you so much
just missing to merge and commit new version in npm

[renatoalvesmh]

Hello
@ottob @uddish any plans to release it ?
Thanks

[CarlMenke]

My boss is waiting for a feature in our app that wont work until this is merged, you guys are life savers if you can get it merged today or tomorrow!

[uddish]

Hey @ottob
Thanks for the PR. Were you able to test it locally?

[ottob]

Were you able to test it locally?

No, but I have basically the same change locally, and it works. And it can not get more broken than it is :)

And I can test it directly when you release a new version.

[ottob]

Ive tested it now locally, and it works for me.

[renatoalvesmh]

@uddish @ottob Thank you! Would be great if it could be released

[MikeMcNamara]

Looks good! Thanks for your work on this folks. Will get this merged in now.

[renatoalvesmh]

Thank you so much @MikeMcNamara
Some plans to bump version in npm ?

[MikeMcNamara]

Version has been bumped now in npm!

[hanyufoodles]

I just tested the plugin with 6.8.0 and it works! I had just to replace config-plugin-react-native-intercom by @intercom/intercom-react-native.

Thank you all for your work! ❤️ we can finally to switch to an official up-to-date plugin!

[ottob]

@MikeMcNamara two steps forward, one step back 😀

#171

[jamesedmonston]

Thanks for this!