fix: find_device_by_name uses timeout_s arg (closes #76)#79
Merged
JPHutchins merged 1 commit intomainfrom Oct 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the find_device_by_name method was not using the provided timeout parameter, ensuring consistent timeout behavior for both address-based and name-based device discovery.
- Added the missing
timeoutparameter toBleakScanner.find_device_by_namecall
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JPHutchins
assigned
davedesro,
KungFuSensai,
robhelvestine,
JerryCapistrano,
aldenhaase,
klam20 and
swoisz
JPHutchins
force-pushed
the
fix/#76/ble-connection-timeout
branch
from
3755e75 to
ad53205
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.