Skip to content

fix: find_device_by_name uses timeout_s arg (closes #76) #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPHutchins merged 1 commit into from
Oct 12, 2025
Merged

fix: find_device_by_name uses timeout_s arg (closes #76) #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smpclient/transport/ble.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ async def connect(self, address: str, timeout_s: float) -> None:
device: BLEDevice | None = (
await BleakScanner.find_device_by_address(address, timeout=timeout_s)
if MAC_ADDRESS_PATTERN.match(address) or UUID_PATTERN.match(address)
else await BleakScanner.find_device_by_name(address)
else await BleakScanner.find_device_by_name(address, timeout=timeout_s)
)

if type(device) is BLEDevice:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_smp_ble_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async def test_connect(
) -> None:
# assert that it searches by name if MAC or UUID is not provided
await SMPBLETransport().connect("device name", 1.0)
mock_find_device_by_name.assert_called_once_with("device name")
mock_find_device_by_name.assert_called_once_with("device name", timeout=1.0)
mock_find_device_by_name.reset_mock()

# assert that it searches by MAC if MAC is provided
Expand Down
Loading