Skip to content

docs(config): add examples on overriding config per-platform#1423

Merged
liamdebeasi merged 10 commits intomasterfrom
config-platform
Jun 10, 2020
Merged

docs(config): add examples on overriding config per-platform#1423
liamdebeasi merged 10 commits intomasterfrom
config-platform

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 15, 2020

@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 14:56 Inactive
@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 14:57 Inactive
@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 15:46 Inactive
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename React's heading to just Platform to match Angular's?

@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 15, 2020 16:51 Inactive
@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 18, 2020 17:10 Inactive

## Platforms

Below is a table listing all the possible `Platforms` values along with corresponding descriptions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Platforms in a code block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? I don't see in a code block.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me add a SS here but this:

Below is a table listing all the possible Platforms values along with corresponding descriptions.

Platforms

liamdebeasi and others added 2 commits May 20, 2020 13:09
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 20, 2020 17:09 Inactive
@perrygovier perrygovier temporarily deployed to ionic-docs-pr-1423 May 20, 2020 17:21 Inactive

## Platforms

Below is a table listing all the possible `Platforms` values along with corresponding descriptions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't let me add a SS here but this:

Below is a table listing all the possible Platforms values along with corresponding descriptions.

Platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants