Skip to content

feat(angular): expose getPlatforms and isPlatform#21308

Merged
liamdebeasi merged 3 commits intomasterfrom
platform-utils
May 22, 2020
Merged

feat(angular): expose getPlatforms and isPlatform#21308
liamdebeasi merged 3 commits intomasterfrom
platform-utils

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented May 15, 2020

blocks ionic-team/ionic-docs#1423

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #17353

What is the new behavior?

  • Export getPlatforms, isPlatform

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi
Copy link
Contributor Author

Need to check and see if this will work with SSR. Might need to add a window check and return [] if SSR

@liamdebeasi liamdebeasi merged commit 4af54a2 into master May 22, 2020
@liamdebeasi liamdebeasi deleted the platform-utils branch May 22, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot override config per platform

1 participant