Skip to content

feat(angular): expose getPlatforms and isPlatform #21308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 3 commits into from
May 22, 2020
Merged

feat(angular): expose getPlatforms and isPlatform #21308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ef3e3d
Export utils
liamdebeasi May 15, 2020
2bd9310
Add ? check
liamdebeasi May 15, 2020
ff7f47c
add SSR check
liamdebeasi May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion angular/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export { IonicRouteStrategy } from './util/ionic-router-reuse-strategy';
export { IonicModule } from './ionic-module';

// UTILS
export { IonicSafeString } from '@ionic/core';
export { IonicSafeString, getPlatforms, isPlatform } from '@ionic/core';

// CORE TYPES
export { Animation, AnimationBuilder, AnimationCallbackOptions, AnimationDirection, AnimationFill, AnimationKeyFrames, AnimationLifecycle, Gesture, GestureConfig, GestureDetail, mdTransitionAnimation, iosTransitionAnimation } from '@ionic/core';
4 changes: 3 additions & 1 deletion core/src/utils/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface IsPlatformSignature {
(win: Window, plt: Platforms): boolean;
}

export const getPlatforms = (win: any) => setupPlatforms(win);
export const getPlatforms = (win?: any) => setupPlatforms(win);

export const isPlatform: IsPlatformSignature = (winOrPlatform: Window | Platforms | undefined, platform?: Platforms) => {
if (typeof winOrPlatform === 'string') {
Expand All @@ -17,6 +17,8 @@ export const isPlatform: IsPlatformSignature = (winOrPlatform: Window | Platform
};

export const setupPlatforms = (win: any = window) => {
if (typeof win === 'undefined') { return []; }

win.Ionic = win.Ionic || {};

let platforms: Platforms[] | undefined | null = win.Ionic.platforms;
Expand Down