feat(virtual-scroll): remove virtual scroll component#25808
Merged
sean-perkins merged 8 commits intofeature-7.0from Aug 24, 2022
Merged
feat(virtual-scroll): remove virtual scroll component#25808sean-perkins merged 8 commits intofeature-7.0from
sean-perkins merged 8 commits intofeature-7.0from
Conversation
github-actions
bot
added
package: angular
liamdebeasi
approved these changes
Aug 24, 2022
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
The code changes look good. Do you have a PR for the documentation changes?
Contributor
Author
|
@liamdebeasi working on that next 👍 I will merge once both are available/approved. |
Contributor
Author
|
Docs PR is available here: ionic-team/ionic-docs#2507 |
averyjohnston
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-virtual-scrollis deprecated and needs to be removed with v7.Issue URL: Internal
What is the new behavior?
Removes all references to
ion-virtual-scrollfromcore,angular,react,vueandangular-server.ion-virtual-scrollcomponentIonicModule(Angular only)Does this introduce a breaking change?
Developers will need to migrate all usages of
ion-virtual-scrollto a supported framework integration:Developers will need to remove/update any references to virtual scroll types:
Cell,VirtualNode,CellType,NodeChange,HeaderFn,ItemHeightFn,HeaderHeightFn,FooterHeightFn,ItemRenderFn, andDomRenderFnthat are imported from@ionic/core.Other information
Dev-build:
6.2.4-dev.11661284341.17fdd471