Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions BREAKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,26 @@ This is a comprehensive list of the breaking changes introduced in the major ver

- [Components](#version-7x-components)
- [Overlays](#version-7x-overlays)
- [Virtual Scroll](#version-7x-virtual-scroll)

<h2 id="version-7x-components">Components</h2>

<h4 id="version-7x-overlays">Overlays</h4>

Ionic now listens on the `keydown` event instead of the `keyup` event when determining when to dismiss overlays via the "Escape" key. Any applications that were listening on `keyup` to suppress this behavior should listen on `keydown` instead.

<h4 id="version-7x-virtual-scroll">Virtual Scroll</h4>

`ion-virtual-scroll` has been removed from Ionic.

Developers using the component will need to migrate to a virtual scroll solution provided by their framework:

- [Angular](https://ionicframework.com/docs/angular/virtual-scroll)
- [React](https://ionicframework.com/docs/react/virtual-scroll)
- [Vue](https://ionicframework.com/docs/vue/virtual-scroll)

Any references to the virtual scroll types from `@ionic/core` have been removed. Please remove or replace these types: `Cell`, `VirtualNode`, `CellType`, `NodeChange`, `HeaderFn`, `ItemHeightFn`, `FooterHeightFn`, `ItemRenderFn` and `DomRenderFn`.


## Version 6.x

Expand Down
1 change: 0 additions & 1 deletion angular/.eslintignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
dist
virtual-scroll
scripts
proxies.ts
2 changes: 1 addition & 1 deletion angular/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"root": true,
"ignorePatterns": ["test/**/*", "src/directives/virtual-scroll/**/*"],
"ignorePatterns": ["test/**/*"],
"overrides": [
{
"files": ["*.ts"],
Expand Down
1 change: 0 additions & 1 deletion angular/.prettierignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
dist
virtual-scroll
scripts
test
src/directives/proxies.ts
Expand Down
11 changes: 0 additions & 11 deletions angular/src/directives/virtual-scroll/virtual-footer.ts

This file was deleted.

11 changes: 0 additions & 11 deletions angular/src/directives/virtual-scroll/virtual-header.ts

This file was deleted.

11 changes: 0 additions & 11 deletions angular/src/directives/virtual-scroll/virtual-item.ts

This file was deleted.

221 changes: 0 additions & 221 deletions angular/src/directives/virtual-scroll/virtual-scroll.ts

This file was deleted.

5 changes: 0 additions & 5 deletions angular/src/directives/virtual-scroll/virtual-utils.ts

This file was deleted.

4 changes: 0 additions & 4 deletions angular/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ export {
} from './directives/navigation/router-link-delegate';

export { NavParams } from './directives/navigation/nav-params';
export { IonVirtualScroll } from './directives/virtual-scroll/virtual-scroll';
export { VirtualItem } from './directives/virtual-scroll/virtual-item';
export { VirtualHeader } from './directives/virtual-scroll/virtual-header';
export { VirtualFooter } from './directives/virtual-scroll/virtual-footer';
export { IonModal } from './directives/overlays/modal';
export { IonPopover } from './directives/overlays/popover';
export * from './directives/proxies';
Expand Down
10 changes: 0 additions & 10 deletions angular/src/ionic-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ import {
import { IonModal } from './directives/overlays/modal';
import { IonPopover } from './directives/overlays/popover';
import { DIRECTIVES } from './directives/proxies-list';
import { VirtualFooter } from './directives/virtual-scroll/virtual-footer';
import { VirtualHeader } from './directives/virtual-scroll/virtual-header';
import { VirtualItem } from './directives/virtual-scroll/virtual-item';
import { IonVirtualScroll } from './directives/virtual-scroll/virtual-scroll';
import { AngularDelegate } from './providers/angular-delegate';
import { ConfigToken } from './providers/config';
import { ModalController } from './providers/modal-controller';
Expand Down Expand Up @@ -50,12 +46,6 @@ const DECLARATIONS = [
NavDelegate,
RouterLinkDelegateDirective,
RouterLinkWithHrefDelegateDirective,

// virtual scroll
VirtualFooter,
VirtualHeader,
VirtualItem,
IonVirtualScroll,
];

@NgModule({
Expand Down
11 changes: 0 additions & 11 deletions angular/test/base/e2e/src/virtual-scroll.spec.ts

This file was deleted.

4 changes: 0 additions & 4 deletions angular/test/base/src/app/app-routing.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { RouterLinkPageComponent } from './router-link-page/router-link-page.com
import { RouterLinkPage2Component } from './router-link-page2/router-link-page2.component';
import { RouterLinkPage3Component } from './router-link-page3/router-link-page3.component';
import { HomePageComponent } from './home-page/home-page.component';
import { VirtualScrollComponent } from './virtual-scroll/virtual-scroll.component';
import { VirtualScrollDetailComponent } from './virtual-scroll-detail/virtual-scroll-detail.component';
import { NestedOutletComponent } from './nested-outlet/nested-outlet.component';
import { NestedOutletPageComponent } from './nested-outlet-page/nested-outlet-page.component';
import { NestedOutletPage2Component } from './nested-outlet-page2/nested-outlet-page2.component';
Expand Down Expand Up @@ -40,8 +38,6 @@ const routes: Routes = [
{ path: 'router-link-page2/:id', component: RouterLinkPage2Component },
{ path: 'router-link-page3', component: RouterLinkPage3Component },
{ path: 'slides', component: SlidesComponent },
{ path: 'virtual-scroll', component: VirtualScrollComponent },
{ path: 'virtual-scroll-detail/:itemId', component: VirtualScrollDetailComponent },
{ path: 'tabs', redirectTo: '/tabs/account', pathMatch: 'full' },
{
path: 'navigation',
Expand Down
6 changes: 0 additions & 6 deletions angular/test/base/src/app/app.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ import { RouterLinkPageComponent } from './router-link-page/router-link-page.com
import { RouterLinkPage2Component } from './router-link-page2/router-link-page2.component';
import { RouterLinkPage3Component } from './router-link-page3/router-link-page3.component';
import { HomePageComponent } from './home-page/home-page.component';
import { VirtualScrollComponent } from './virtual-scroll/virtual-scroll.component';
import { VirtualScrollDetailComponent } from './virtual-scroll-detail/virtual-scroll-detail.component';
import { VirtualScrollInnerComponent } from './virtual-scroll-inner/virtual-scroll-inner.component';
import { NestedOutletComponent } from './nested-outlet/nested-outlet.component';
import { NestedOutletPageComponent } from './nested-outlet-page/nested-outlet-page.component';
import { NestedOutletPage2Component } from './nested-outlet-page2/nested-outlet-page2.component';
Expand All @@ -44,9 +41,6 @@ import { AccordionModalComponent } from './accordion/accordion-modal/accordion-m
RouterLinkPage2Component,
RouterLinkPage3Component,
HomePageComponent,
VirtualScrollComponent,
VirtualScrollDetailComponent,
VirtualScrollInnerComponent,
NestedOutletComponent,
NestedOutletPageComponent,
NestedOutletPage2Component,
Expand Down
Loading