refactor(toast): deprecate cssClass on ToastButton#27959
Merged
liamdebeasi merged 4 commits intofeature-7.4from Aug 23, 2023
Merged
refactor(toast): deprecate cssClass on ToastButton#27959liamdebeasi merged 4 commits intofeature-7.4from
liamdebeasi merged 4 commits intofeature-7.4from
Conversation
|
|
liamdebeasi
changed the title
liamdebeasi
changed the title
liamdebeasi
requested review from
a team and
sean-perkins
and removed request for
a team
sean-perkins
approved these changes
Aug 9, 2023
brandyscarney
approved these changes
Aug 9, 2023
Member
|
Might want to point this at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
As part of our work for the cancel CSS Shadow Part for toast buttons, we decided to deprecate the
cssClassproperty onion-toast. This feature stopped working once we migratedion-toastto the Shadow DOM.What is the new behavior?
cssClassproperty onIonToast.Does this introduce a breaking change?
Other information
Do not merge until #27921 is merged.