Skip to content

refactor(toast): deprecate cssClass on ToastButton #27959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 4 commits into from
Aug 23, 2023
Merged

refactor(toast): deprecate cssClass on ToastButton #27959

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8101c7e
chore: deprecate cssClass on ToastButton
liamdebeasi Aug 9, 2023
ea74059
add TODO
liamdebeasi Aug 9, 2023
abe5fb0
Merge branch 'feature-7.3' into toast-button-css-class
liamdebeasi Aug 22, 2023
7d4c271
Merge branch 'feature-7.4' into toast-button-css-class
liamdebeasi Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/src/components/toast/toast-interface.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,17 @@ export interface ToastOptions {

export type ToastLayout = 'baseline' | 'stacked';

// TODO FW-4923 remove cssClass property

export interface ToastButton {
text?: string;
icon?: string;
side?: 'start' | 'end';
role?: 'cancel' | string;

/**
* @deprecated Use the toast button's CSS Shadow Parts instead.
*/
cssClass?: string | string[];
htmlAttributes?: { [key: string]: any };
handler?: () => boolean | void | Promise<boolean | void>;
Expand Down