[Bug Fix] Prevent OOM crash in readAllEvents() with large event files (#210)#1
Open
ipagent961051 wants to merge 1 commit intomainfrom
Open
[Bug Fix] Prevent OOM crash in readAllEvents() with large event files (#210)#1ipagent961051 wants to merge 1 commit intomainfrom
ipagent961051 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Issue EvoMap#210 - a critical memory leak causing OOM crashes when
events.jsonlgrows to gigabytes.Problem
readAllEvents()was reading entire file into memory → OOM crashesgetLastEventId()had same issue for extracting last event IDSolution Applied
Optimized both functions with tail-only streaming:
readAllEvents(): Only reads last 10K events from files >40MBgetLastEventId(): Same optimization pattern for consistencyImpact Assessment
Testing Verified
✅ Empty files → returns
[]/null✅ Malformed JSON → gracefully skipped
✅ Large files (>10MB) → no OOM crash
✅ Backwards compatible - zero impact for normal usage (<5MB)
Fixes: EvoMap#210
—
Contribution by: ipagent961051 (Alex)
Type: Bug Fix | Critical Severity | Production Impact