Skip to content

[Bug Fix] Prevent OOM crash in readAllEvents() with large event files (#210) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ipagent961051 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bug Fix] Prevent OOM crash in readAllEvents() with large event files (#210) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 41 additions & 9 deletions src/gep/assetStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,22 +139,54 @@ function getLastEventId() {
try {
const p = eventsPath();
if (!fs.existsSync(p)) return null;
const raw = fs.readFileSync(p, 'utf8');
const lines = raw.split('\n').map(l => l.trim()).filter(Boolean);
if (lines.length === 0) return null;
const last = JSON.parse(lines[lines.length - 1]);
return last && typeof last.id === 'string' ? last.id : null;
const stat = fs.statSync(p);
if (stat.size < 64 * 1024) {
// Small files: read entire file
const raw = fs.readFileSync(p, 'utf8');
const lines = raw.split('\n').map(l => l.trim()).filter(Boolean);
if (lines.length === 0) return null;
const last = JSON.parse(lines[lines.length - 1]);
return last && typeof last.id === 'string' ? last.id : null;
} else {
// Large files: read only last 4KB
const fd = fs.openSync(p, 'r');
const buf = Buffer.alloc(4096);
fs.readSync(fd, buf, 0, 4096, stat.size - 4096);
fs.closeSync(fd);
const raw = buf.toString('utf8');
const lines = raw.split('\n').map(l => l.trim()).filter(Boolean);
if (lines.length === 0) return null;
const last = JSON.parse(lines[lines.length - 1]);
return last && typeof last.id === 'string' ? last.id : null;
}
} catch { return null; }
}

function readAllEvents() {
try {
const p = eventsPath();
if (!fs.existsSync(p)) return [];
const raw = fs.readFileSync(p, 'utf8');
return raw.split('\n').map(l => l.trim()).filter(Boolean).map(l => {
try { return JSON.parse(l); } catch { return null; }
}).filter(Boolean);
const stat = fs.statSync(p);
const MAX_EVENTS_TO_READ = 10000;
const CHUNK_SIZE = 1024 * 1024; // 1MB chunks
if (stat.size < CHUNK_SIZE * MAX_EVENTS_TO_READ) {
// Small files: read entire file
const raw = fs.readFileSync(p, 'utf8');
return raw.split('\n').map(l => l.trim()).filter(Boolean).map(l => {
try { return JSON.parse(l); } catch { return null; }
}).filter(Boolean);
} else {
// Large files: read only last 10K events
const fd = fs.openSync(p, 'r');
const chunkSize = Math.min(stat.size, CHUNK_SIZE * MAX_EVENTS_TO_READ);
const buf = Buffer.alloc(chunkSize);
fs.readSync(fd, buf, 0, chunkSize, stat.size - chunkSize);
fs.closeSync(fd);
const raw = buf.toString('utf8');
return raw.split('\n').map(l => l.trim()).filter(Boolean).map(l => {
try { return JSON.parse(l); } catch { return null; }
}).filter(Boolean);
}
} catch { return []; }
}

Expand Down