-
Notifications
You must be signed in to change notification settings - Fork 148
refactor(examples): proxy gateway to use exchange #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 48.02% 48.14% +0.12%
==========================================
Files 269 269
Lines 32957 32962 +5
==========================================
+ Hits 15827 15870 +43
+ Misses 15454 15428 -26
+ Partials 1676 1664 -12
|
hacdias
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tbf, when I wrote this for the first time I wasn't really aware of the other abstractions (like the exchange). It does indeed make more sense to use it.
e56fa3b to
aa107c6
Compare
|
I rebased on top of #246 since I made quite a few changes to the examples there and we enabled more conformance tests, just to run more tests here. |
0862a5f to
725a8f4
Compare
aa107c6 to
028e9a5
Compare
028e9a5 to
928df5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased since bunch of refactor had overlap with #246, now this PR is much smaller. lgtm
Using a blockstore isn't really the right interface here (e.g.
Hasdoesn't really make any sense). Theexchange.Interfaceor better theexchange.Fetcherinterfaces are more appropriate and less confusing.This also removes all the
notImplementederrors. The functions not implemented are essentially optional, so descriptions as to what they are for have been left there but they otherwise should not cause issues.Note: there seems to be some good cause here to simplify the examples (and make them more production-like) by adding:
exchange.Fetcher.Both of these are effectively implemented in bifrost-gateway (ipfs-inactive/bifrost-gateway#61). So once we're happy with how things pan out there we should consider porting implementations back to boxo.
Explicitly looking for feedback such as:
Other feedback welcome too 😄