-
Notifications
You must be signed in to change notification settings - Fork 148
ci(gateway): enable subdomain conformance #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 47.87% 48.15% +0.28%
==========================================
Files 269 269
Lines 32976 32957 -19
==========================================
+ Hits 15787 15871 +84
+ Misses 15514 15422 -92
+ Partials 1675 1664 -11
|
0bc8590 to
d95ed57
Compare
d95ed57 to
0862a5f
Compare
0862a5f to
725a8f4
Compare
lidel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🚢
(while looking at this, found unrelated nit: #176 (review))
This PR enables the subdomain conformance gateway tests (added in #237). Since we are using the CAR example to run the Gateway tests, we need to make it more conformant, of course, similarly to what happened in ipfs-inactive/bifrost-gateway#66.
example.net(domain used in examples)CONNECTsupport to the gateway examples.commonsubpackage since it was the same for both examples.