Skip to content

Conversation

@lidel
Copy link
Member

@lidel lidel commented Sep 5, 2024

@codecov
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 68.79195% with 279 lines in your changes missing coverage. Please review.

Project coverage is 60.26%. Comparing base (adb0591) to head (41b8882).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
mfs/dir.go 5.55% 51 Missing ⚠️
tar/extractor.go 66.99% 18 Missing and 16 partials ⚠️
gateway/handler.go 42.59% 27 Missing and 4 partials ⚠️
mfs/file.go 62.33% 21 Missing and 8 partials ⚠️
ipld/unixfs/pb/unixfs.pb.go 27.77% 26 Missing ⚠️
files/multipartfile.go 69.23% 12 Missing and 4 partials ⚠️
mfs/ops.go 7.69% 12 Missing ⚠️
files/meta.go 42.10% 8 Missing and 3 partials ⚠️
ipld/unixfs/importer/helpers/dagbuilder.go 69.69% 8 Missing and 2 partials ⚠️
gateway/backend_car_files.go 0.00% 8 Missing ⚠️
... and 14 more

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #670      +/-   ##
==========================================
+ Coverage   59.97%   60.26%   +0.28%     
==========================================
  Files         237      241       +4     
  Lines       29955    30707     +752     
==========================================
+ Hits        17965    18505     +540     
- Misses      10378    10555     +177     
- Partials     1612     1647      +35     
Files with missing lines Coverage Δ
bitswap/client/client.go 88.12% <ø> (ø)
bitswap/server/internal/decision/engine.go 91.78% <100.00%> (-0.06%) ⬇️
blockservice/internal/tracing.go 100.00% <100.00%> (ø)
examples/bitswap-transfer/main.go 41.21% <ø> (ø)
files/linkfile.go 67.85% <100.00%> (+27.85%) ⬆️
files/multifilereader.go 85.84% <100.00%> (+3.04%) ⬆️
files/readerfile.go 74.00% <100.00%> (+26.63%) ⬆️
files/slicedirectory.go 80.95% <100.00%> (+7.61%) ⬆️
files/webfile.go 68.42% <100.00%> (+12.32%) ⬆️
gateway/gateway.go 83.54% <ø> (ø)
... and 27 more

... and 13 files with indirect coverage changes

@lidel lidel marked this pull request as ready for review September 5, 2024 21:45
@lidel lidel requested a review from a team as a code owner September 5, 2024 21:45
@lidel lidel merged commit 171b0b7 into main Sep 5, 2024
@gammazero gammazero mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants