Skip to content

Conversation

@gammazero
Copy link
Contributor

@gammazero gammazero commented Oct 22, 2024

No description provided.

gammazero and others added 14 commits October 3, 2024 11:52
btswap client does not need ProviderQueryManager

The bitswap Client does not to hold a reference to the provider query manager. The session maintains the ProviderQueryManager reference.
Otherwise live wants get rebroadcasted/requested forever, even when we cancelled those.
fix(bitswap/session): cleanup live wants on cancel
- Fix exhausted wants problem resulting in possible performance issue
- Minor improvements for GC.
- RWLock not justified for time reading
- replace unneeded RWMutex with Mutex
- build strings with strings.Builder
- update dependencies
- Use sync/atomic instead of uber/atomic
- mod tidy examples
- test sharness with go1.23
- update go-unixfsnode
- fix: extra go mod tidy
@gammazero gammazero added release Merging this PR will create a tagged release and removed skip/changelog labels Oct 22, 2024
@github-actions
Copy link

Suggested version: 0.24.1

Comparing to: v0.24.0 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

# diagnostics
go.mod: the following requirements are needed
	go.opentelemetry.io/otel/exporters/jaeger@v1.14.0
Run 'go mod tidy' to add missing requirements.
required module github.com/gabriel-vasile/mimetype@v1.4.4 retracted by module author: v1.4.4 had a test file detected as malicious by antivirus software. #575
required module github.com/microcosm-cc/bluemonday@v1.0.1 retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Suggested version: v0.24.1

gocompat says:

HEAD is now at 2fdde029d Merge pull request #683 from ipfs/release-v0.24.0
Switched to branch 'release'
Your branch is up to date with 'origin/release'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 64.15094% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (2fdde02) to head (d38ca57).

Files with missing lines Patch % Lines
mfs/repub.go 12.50% 7 Missing ⚠️
bootstrap/bootstrap.go 0.00% 5 Missing ⚠️
bitswap/client/internal/session/sessionwants.go 62.50% 2 Missing and 1 partial ⚠️
...wap/client/internal/peermanager/peerwantmanager.go 80.00% 1 Missing ⚠️
...wap/client/internal/session/peerresponsetracker.go 50.00% 1 Missing ⚠️
...tswap/client/internal/session/sessionwantsender.go 66.66% 0 Missing and 1 partial ⚠️
...p/client/internal/sessionmanager/sessionmanager.go 66.66% 1 Missing ⚠️

Impacted file tree graph

@@             Coverage Diff             @@
##           release     #696      +/-   ##
===========================================
- Coverage    60.42%   60.41%   -0.01%     
===========================================
  Files          243      243              
  Lines        31004    31033      +29     
===========================================
+ Hits         18733    18749      +16     
- Misses       10611    10620       +9     
- Partials      1660     1664       +4     
Files with missing lines Coverage Δ
bitswap/client/client.go 90.38% <100.00%> (+2.26%) ⬆️
...tswap/client/internal/messagequeue/messagequeue.go 84.92% <100.00%> (-1.00%) ⬇️
...wap/client/internal/notifications/notifications.go 87.35% <100.00%> (+0.29%) ⬆️
bitswap/client/internal/peermanager/peermanager.go 91.72% <ø> (ø)
bitswap/network/ipfs_impl.go 75.53% <100.00%> (+0.26%) ⬆️
gateway/blockstore.go 0.00% <ø> (ø)
routing/http/client/client.go 70.83% <100.00%> (+0.08%) ⬆️
routing/http/filters/filters.go 82.63% <100.00%> (+0.12%) ⬆️
...wap/client/internal/peermanager/peerwantmanager.go 88.50% <80.00%> (+0.16%) ⬆️
...wap/client/internal/session/peerresponsetracker.go 96.15% <50.00%> (+3.05%) ⬆️
... and 5 more

... and 12 files with indirect coverage changes

@gammazero
Copy link
Contributor Author

Wrong base

@gammazero gammazero closed this Oct 22, 2024
@gammazero gammazero deleted the release-v0.24.1 branch October 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Merging this PR will create a tagged release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants