Skip to content

feat: add protocol and address filtering to delegated routing api #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gammazero merged 10 commits into from
Oct 1, 2024
Merged

feat: add protocol and address filtering to delegated routing api #678

gammazero merged 10 commits into from
Oct 1, 2024

Conversation

@2color
Copy link
Member

@2color 2color commented Oct 1, 2024 •
edited
Loading

What's in this PR

  • Adds client protocol and address filtering according to IPIP-484 to the HTTP Client

Notes

  • Since not all delegated routing servers support IPIP-484, e.g. IPNI, client side filtering is enabled by default, and needs to be disabled with WithDisabledLocalFiltering

@2color 2color requested a review from a team as a code owner October 1, 2024 07:48
@codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 26 lines in your changes missing coverage. Please review.

Project coverage is 60.30%. Comparing base (19a402b) to head (aba566c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
routing/http/client/client.go 51.42% 15 Missing and 2 partials ⚠️
routing/http/filters/filters.go 73.52% 6 Missing and 3 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   60.36%   60.30%   -0.07%     
==========================================
  Files         243      243              
  Lines       30953    31004      +51     
==========================================
+ Hits        18684    18696      +12     
- Misses      10612    10641      +29     
- Partials     1657     1667      +10
Files with missing lines Coverage Δ
routing/http/server/server.go 74.08% <100.00%> (+1.41%) ⬆️
routing/http/filters/filters.go 82.51% <73.52%> (ø)
routing/http/client/client.go 70.75% <51.42%> (-2.26%) ⬇️

... and 11 files with indirect coverage changes

This was referenced Oct 1, 2024
Closed
Merged
gammazero
gammazero approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidel lidel mentioned this pull request Oct 1, 2024
Closed
34 tasks
@gammazero gammazero added the P1 High: Likely tackled by core team if no one steps up label Oct 1, 2024
@gammazero gammazero merged commit 4d0ae45 into main Oct 1, 2024
@gammazero gammazero deleted the add-client-filtering branch October 1, 2024 22:43
@lidel lidel mentioned this pull request Oct 4, 2024
Merged
3 tasks
wenyue pushed a commit to wenyue/boxo that referenced this pull request Oct 17, 2024
@2color @gammazero @wenyue
feat: add protocol and address filtering to delegated routing api (ip…
e114022 
…fs#678)

* feat: add filtering on client
* refactor: abstract add filters to url function
* feat: add client filtering to FindPeers
* test: test filtering in findPeers

---------

Co-authored-by: Daniel N <2color@users.noreply.github.com>
Co-authored-by: gammazero <11790789+gammazero@users.noreply.github.com>
@gammazero gammazero mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gammazero gammazero gammazero approved these changes

Assignees

No one assigned

Labels

P1 High: Likely tackled by core team if no one steps up

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2color @gammazero