Conversation
Member
|
We have a Go 1.18 x86 heavy-flaky test in here that needs to be addressed: #379 We have enough flaky stuff to deal with in here already, best ensure this one gets sorted out properly since it seems to be a much more consistent flaky than the others we have which are hard to repro. |
web3-bot
force-pushed
the
web3-bot/sync
branch
5 times, most recently
from
5702b27 to
9175019
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
2 times, most recently
from
6da7eb6 to
3613ec0
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
3 times, most recently
from
bf1a9e8 to
301ed9d
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
2 times, most recently
from
94c79df to
352a3a5
Compare
Contributor
|
@rvagg all the tests passed now. Do you think I could merge it and update the required checks to the Go 1.17 ones? |
web3-bot
force-pushed
the
web3-bot/sync
branch
2 times, most recently
from
b25ea1a to
6821808
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
from
6821808 to
3384e91
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
6 times, most recently
from
a616822 to
933d863
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
2 times, most recently
from
fa6304f to
82b149a
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
3 times, most recently
from
8403517 to
6bfbce7
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
6 times, most recently
from
c83f2d1 to
efa2426
Compare
web3-bot
force-pushed
the
web3-bot/sync
branch
from
efa2426 to
063c9f9
Compare
Member
|
doh! blocked again but now on the dtls / quic thing |
Member
|
ready to merge but I think it needs to be override-merged which I can't do, "Waiting for status to be reported" on non-existent 1.18.x runners; I'm not even sure where they come from since this now doesn't have 1.18. |
galargh
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing to commit protocol/.github@2aab7c0.