Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
is this a new test becoming flaky with these dependency updates? |
|
another flaky test: |
|
Additional note: required github checks will need to be updated with this change to point to the newer golang versions |
|
TestGraphsyncRoundTripIgnoreNBlocks flaky documented @ #379 and was blocking the unified-ci upgrade. I was holding off #378 because I didn't want such a badly flaky test to be introduced as we've already got a few to deal with here and this one seems particularly flaky. TestCancellationQueryInProgress I don't recall being flaky, but since it's failing on the tracing then I'm inclined to believe it was—there's a few tests where the tracing is a bit too strict and they need to be wound back a bit. |
|
Other than TestGraphsyncRoundTripIgnoreNBlocks this lgtm, I'm just not super keen on pushing ahead without figuring out why that one's so bad, or coming up with a strategy to stop it being such a problem for CI going forward. I think it's only for x86 so if there's a way to skip it for that then that's probably fine. |
53b328d to
ad8b824
Compare
* bump go.mod to Go 1.18 and run go fix * stop using the deprecated io/ioutil package * bump go.mod to Go 1.18 and run go fix * update .github/workflows/automerge.yml * update .github/workflows/go-test.yml * update .github/workflows/go-check.yml * mechanical updates for libp2p v0.22 * bump testplan to working versions * bump more versions * more deps * fix static checks * chore(deps): update to tagged deps Co-authored-by: web3-bot <web3-bot@users.noreply.github.com> Co-authored-by: willscott <will.scott@protocol.ai> Co-authored-by: hannahhoward <hannah@hannahhoward.net>
should use versioned deps after
ipfs/go-peertaskqueue#25
ipfs/go-ipfs-routing#36