This repository was archived by the owner on Aug 1, 2023. It is now read-only.
Closed
Conversation
ghost
assigned
It looks like these were accidentally disabled along with pubsub and then never re-enabled.
Stebalien
force-pushed
the
fix/re-enable-exchange-tests
branch
from
297d508 to
39c8914
Compare
This was referenced Nov 3, 2018
Member
|
done in master + more goodies (I didn't see this PR before starting #44) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like these were accidentally disabled along with pubsub and then never re-enabled.
Note: I can't get these tests to pass locally. It looks like js-ipfs gets stuck in an infinite loop somewhere and doesn't even respond toLooks like a Node 11 issue (nodejs/node#23860)kill(node bug on my machine?).